Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply URL encode/decode changes #11330

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jul 21, 2024
@Stypox Stypox mentioned this pull request Jul 25, 2024
@Isira-Seneviratne Isira-Seneviratne force-pushed the Java-10-URL-NP branch 4 times, most recently from f0c261b to 2b0bfb4 Compare July 26, 2024 03:34
Copy link

sonarcloud bot commented Jul 26, 2024

Copy link

@acrodemocide acrodemocide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. I'll install the APK from the build and test on my Android. Once that tests correctly, I'll come back and approve.

@ShareASmile ShareASmile added the codequality Improvements to the codebase to improve the code quality label Sep 5, 2024
Copy link
Contributor

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out for the DownloadSettings, it’s fine.

Recaptcha change is straightforward.

Copy link

sonarcloud bot commented Nov 19, 2024

@Profpatsch Profpatsch merged commit ffcba17 into TeamNewPipe:dev Nov 19, 2024
6 checks passed
@Isira-Seneviratne Isira-Seneviratne deleted the Java-10-URL-NP branch November 22, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants