NewPipe Settings page redesign - Part 1 #10490
Conversation
* Added a new page to display the redesigned settings page. * Added an entry in the `SettingsResourceRegistry`. * Created a new `MainSettingsV2Fragment` that is the same as `MainSettingsFragment` but provides the redesigned page. * This is necessary to prevent development of new settings from affecting and complicating the existing implementation. * This also provides a way to develop and test the redesign without affecting release builds. * The `MainSettingsFragment` can be removed once the new settings page is released. **Screenshot:** <img src="https://github.com/TeamNewPipe/NewPipe/assets/87667048/3f29c319-224d-4b5b-8c0c-8178e413cfb1" alt="NewPipe_Settings_Screen_Missing_Icons" width=300 height=650> **Note:** These changes are not final. This PR is to demonstrate and discuss icons for the new entries.
|
Kudos, SonarCloud Quality Gate passed! |
|
Awesome! Only the Player menu can be opened right now. Is that intended? Also, it would help to mention that the new layout is to be enabled via debug settings. (BTW, since debug settings can't be opened in the new layout, there's no way to switch back.) |
Both these things are intended in the current state. This PR is only meant as a demo of how I plan to move ahead. The click destinations are not implemented right now. The Player menu opens the old My plan is to get an initial confirmation here before moving ahead with rest of the changes. I will make sure to implement debug menu first so that we can switch back. The concern right now is the icons for new entries @opusforlife2 Can you help with this
Thanks. Added information for this in the description. |
|
@Stypox knows all the material icons like the back of his hand. |
|
I have chosen to implement this without the icons for now in #10849. The new page is guarded by a debug settings option, so it should be safe to do so. I am closing this PR as it was only meant as a proof of concept. Thank you for your understanding. |
What is it?
Description of the changes in your PR
SettingsResourceRegistry.MainSettingsV2Fragmentthat is the same asMainSettingsFragmentbut provides the redesigned page.MainSettingsFragmentcan be removed once the new settings page is released.Note: These changes are not final. This PR is to demonstrate and discuss icons for the new entries.
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence