Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink pure listed files #390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rethink pure listed files #390

wants to merge 1 commit into from

Conversation

velzie
Copy link
Collaborator

@velzie velzie commented Aug 17, 2024

there's been a lot of complaints about the pure list being overzealous. i've moved:

  • everything in gfx
  • sounds/items
  • sounds/players

into the editable pk3s, as there's no competitive advantage you could feasibly draw from modifying them

this may have unintended side effects! needs testing

@haha-goodone-lol
Copy link

there's a clear competitive advantage you can get from changing item pickup sounds, you can change the pickup sounds to something loud like a voice saying "Red armor picked up" or "Item spawned"
also just a suggestion, would it be possible to organise the sounds/players/<model> into folders like having rkill vsays gameplay, it would be easy for others to edit them

@margarinoslv
Copy link

there's a clear competitive advantage you can get from changing item pickup sounds, you can change the pickup sounds to something loud like a voice saying "Red armor picked up" or "Item spawned" also just a suggestion, would it be possible to organise the sounds/players/<model> into folders like having rkill vsays gameplay, it would be easy for others to edit them

Correct me if I'm wrong but I'm pretty sure the pickup sound plays at a SET distance and it doesn't quite matter how loud the sound itself is.

@haha-goodone-lol
Copy link

in warsow, the gfx folder isn't pured and it doesnt seem like it'd have a competitive advantage

@margarinoslv
Copy link

in warsow, the gfx folder isn't pured and it doesnt seem like it'd have a competitive advantage

indeed, i vouch for it being removed from pure

@aw2p
Copy link

aw2p commented Aug 22, 2024

Much needed change thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants