Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boost pads in maps #316

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gelmo
Copy link
Member

@Gelmo Gelmo commented Mar 1, 2024

Also added quake1.as to the gt file for Rekt to improve support with non-official maps

Credit @DenMSC

@Gelmo
Copy link
Member Author

Gelmo commented Mar 1, 2024

@DenMSC can you confirm here that you approve of your boost code being contributed to Warfork?

@Warfork
Copy link
Member

Warfork commented Mar 1, 2024

@CoolElectronics if we get approval from msc please merge this if it's fine thanks

@Gelmo Gelmo marked this pull request as draft March 1, 2024 23:43
@Gelmo
Copy link
Member Author

Gelmo commented Mar 1, 2024

Converted to draft due to discussion in Advisors channel. MSC says there's a better way to implement this that will give mappers more flexibility in the boost behavior - https://github.com/hettoo/wsw-race/blob/racemod/source/progs/gametypes/hrace/entities/trigger_push_velocity.as

@Gelmo
Copy link
Member Author

Gelmo commented Mar 2, 2024

MSC recalls there being a bug with trigger_push_velocity.as:

[01:23]msc: have some broken jumppad in wsw race on miragul
[01:23]msc: wondering if my implementation is wrong or the entitied.def is wrong here
[01:24]msc:
{
  "speed": "100",
  "spawnflags": "8",
  "classname": "trigger_push_velocity"
}
[01:24]msc: spawnflags 8 is ADD_Z, for reference
[01:24]msc: according to the entities.def:
speed: XY speed for player-directional velocity pads - either sets or adds to the player's horizontal velocity.
count: Z speed for player-directional velocity pads - either sets or adds to the player's vectical velocity.
[01:25]msc: does this not matter for ADD variants or something?
[01:25]msc: kinda confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants