forked from Qfusion/qfusion
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mod mem to ref gl #310
Draft
pollend
wants to merge
8
commits into
master
Choose a base branch
from
feature/add-mod-mem-to-refgl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
force-pushed
the
feature/add-mod-mem-to-refgl
branch
from
February 26, 2024 15:52
c4d7588
to
da794ec
Compare
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
pollend
force-pushed
the
feature/add-mod-mem-to-refgl
branch
from
February 26, 2024 16:10
da794ec
to
ef06cec
Compare
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
pollend
force-pushed
the
feature/add-mod-mem-to-refgl
branch
from
February 27, 2024 06:43
20d3b42
to
144fbd4
Compare
pollend
commented
Feb 27, 2024
@@ -878,12 +889,14 @@ void Mod_Modellist_f( void ) | |||
*/ | |||
void R_InitModels( void ) | |||
{ | |||
mod_mempool = R_AllocPool( r_mempool, "Models" ); | |||
mod_mempool = Q_CreatePool(NULL, "Models"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a module by default this will use the pool under cl_vid
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add mod mem to to ref_gl module and fixed assertion for mem.c