Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should fix The-Fireplace/Mechanical-Soldiers#9 #87

Closed
wants to merge 1 commit into from
Closed

Should fix The-Fireplace/Mechanical-Soldiers#9 #87

wants to merge 1 commit into from

Conversation

The-Fireplace
Copy link
Contributor

@The-Fireplace The-Fireplace commented Aug 3, 2017

That crash should have been impossible, because an ItemStack's item should never be null, but for some reason, it looks like that's what it was. That is the only possible null in the line of code the crash report pointed to, the stack was null checked.

@The-Fireplace
Copy link
Contributor Author

This closes #86 .

@TehNut
Copy link
Member

TehNut commented Aug 20, 2017

I still feel like this is not needed. Since it's crashing on an oredict recipe, then somebody is probably adding an invalid stack to the oredict.

If you look through the client log, you can actually see JEI spamming errors around line 30847 about null items in stacks.

@The-Fireplace
Copy link
Contributor Author

Ok, good point. Perhaps rather than crashing, Guide API should also spam errors when this happens, and handle the issue somehow. Even if it means skipping the page or something, it would still be better than crashing the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants