-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat :: 메인 배너 api 연동 #65
Open
dnjsdmswl
wants to merge
3
commits into
main
Choose a base branch
from
feature/52-BannerApi
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+78
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
dnjsdmswl
requested review from
a team,
eejx0,
KANGYONGSU23 and
JJIIIINN
and removed request for
a team
April 7, 2024 06:01
JJIIIINN
reviewed
Apr 8, 2024
BOOKMARK: "/", | ||
NONE: "/", | ||
INTERNSHIP: "/recruitments/?page=1", | ||
COMPANY: "/companies/detail/?id=`${id}`", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Company 잘 동작하는 지 테스트 해봤나요?
이렇게 하면 동작 안 할텐데.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API에서 id 보내주는게 없어서 수정 요청하였고
코드는 임시로 넣어놨습니다
jikwan0327
approved these changes
Apr 20, 2024
conflict 고쳐주세요 |
KANGYONGSU23
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
특이사항
관련 이슈