Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat :: 메인 배너 api 연동 #65

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

dnjsdmswl
Copy link
Contributor

특이사항

관련 이슈

@dnjsdmswl dnjsdmswl linked an issue Apr 7, 2024 that may be closed by this pull request
@dnjsdmswl dnjsdmswl requested review from a team, eejx0, KANGYONGSU23 and JJIIIINN and removed request for a team April 7, 2024 06:01
@dnjsdmswl dnjsdmswl self-assigned this Apr 7, 2024
src/apis/banners/type.ts Outdated Show resolved Hide resolved
src/components/Carousel.tsx Outdated Show resolved Hide resolved
src/components/Carousel.tsx Outdated Show resolved Hide resolved
src/components/Carousel.tsx Outdated Show resolved Hide resolved
BOOKMARK: "/",
NONE: "/",
INTERNSHIP: "/recruitments/?page=1",
COMPANY: "/companies/detail/?id=`${id}`",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Company 잘 동작하는 지 테스트 해봤나요?
이렇게 하면 동작 안 할텐데.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API에서 id 보내주는게 없어서 수정 요청하였고
코드는 임시로 넣어놨습니다

@jikwan0327
Copy link
Member

conflict 고쳐주세요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

배너 API 연동
4 participants