Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register custom MPI operator for aarch64 #287

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Register custom MPI operator for aarch64 #287

merged 2 commits into from
Nov 15, 2024

Conversation

giordano
Copy link
Member

I still need to test this, but opening to remind myself to look into this.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.46%. Comparing base (2403cc9) to head (aa33cc8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files           7        7           
  Lines         385      385           
=======================================
  Hits          356      356           
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giordano
Copy link
Member Author

Well, now we're testing this on CI on aarch64-darwin, and it seems to be working fine 🙂 CC: @sguillas.

@giordano giordano marked this pull request as ready for review November 15, 2024 15:08
@giordano giordano merged commit c55ea63 into main Nov 15, 2024
13 checks passed
@giordano giordano deleted the mg/mpi-register-op branch November 15, 2024 15:42
@giordano
Copy link
Member Author

For the record, I ran the tests successfully on both A64FX and Nvidia Grace (besides the fact we're now testing the package on aarch64-darwin, too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant