-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra links to README and improve description #264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 92.48% 92.48%
=======================================
Files 7 7
Lines 386 386
=======================================
Hits 357 357
Misses 29 29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now renamed the branch, so should replace master
-> main
everywhere. Sorry! 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to change master_rank
→ main_rank
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially yes, but it can be done in a separate PR. Also, it'd probably be a technically breaking change, as I think we expose the name to users at
Line 6 in 1618055
* `master_rank` : Id of MPI rank that performs serial computations |
Looks like there is some implicit reference to
when running using PkgBenchmark, BenchmarkCI
BenchmarkCI.judge(
PkgBenchmark.BenchmarkConfig(
env = Dict(
"JULIA_NUM_THREADS" => "2",
),
),
) but not sure how to fix - @giordano any ideas?
(Second) EDIT: Looks like culprit is |
Adds badges to README for latest stable version of documentation and GMD journal article (will need to be updated once the accepted version is available online). Also tweaks the description a little bit to mention thread-based parallelism and add a link to ARC website. I also noticed there was a
unit_test.h5
HDF5 file we don't appear to use anywhere that was added in #218, I assumne accidentally, so have removed this.