Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

37 book order #38

Merged
merged 7 commits into from
Apr 5, 2024
Merged

37 book order #38

merged 7 commits into from
Apr 5, 2024

Conversation

ta2ye0n
Copy link
Contributor

@ta2ye0n ta2ye0n commented Apr 5, 2024

πŸ’‘ κ°œμš”

μ±… μ‹ μ²­ api λ₯Ό λ§Œλ“€μ—ˆμŠ΅λ‹ˆλ‹€

πŸ“ƒ μž‘μ—…λ‚΄μš©

μ±… 제λͺ©, μž‘κ°€, 책이 νŒŒλŠ” 곳의 urlλ₯Ό 적어 책을 μ‹ μ²­ν•  수 μžˆμŠ΅λ‹ˆλ‹€.

requestParams 둜 NOVEL/ ESSAY λ°›μ•„μ˜€κ³  dbμ—λŠ” 숫자둜 μ €μž₯λ©λ‹ˆλ‹€ NOVEL = 0 , ESSAY = 1

πŸ”€ 변경사항

πŸ™‹β€β™‚οΈ μ§ˆλ¬Έμ‚¬ν•­

βš—οΈ μ‚¬μš©λ²•

🎸 기타


@PostMapping("/list")
public ResponseEntity<Void> bookRequest
(@RequestParam BookType type, @RequestBody @Valid OrderRequest bookRequest) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λͺ…μ„Έμ„œλ₯Ό ν™•μΈν•΄λ³΄λ‹ˆκΉŒ orderμ—μ„œλŠ” postμš”μ²­μ΄ ν•˜λ‚˜λ°–μ— μ—†λŠ” κ±° 같은데 μ—”λ“œν¬μΈνŠΈλ₯Ό μ„€μ •ν•˜μ‹  μ΄μœ κ°€ μžˆλ‚˜μš”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ecd26fe

λ‹€λ₯Έ λΆ€λΆ„ λͺ…μ„Έμ„œλž‘ ν˜Όλ™λ˜μ„œ 잘λͺ»μ“΄κ±°κ°™μ•„μš” μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€

(@RequestParam BookType type, @RequestBody @Valid OrderRequest bookRequest) {
bookRequestService.execute(type, bookRequest);
return ResponseEntity.ok().build();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신청이 μƒμ„±λ˜μ—ˆλ‹€λŠ” 의미둜 createλŠ” μ–΄λ–€κ°€μš”??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κΈ°λŠ₯이 책을 μ‹ μ²­ν•˜λŠ”κ±°λΌμ„œ λ•Œλ¬Έμ— requestκ°€ 더 μ§κ΄€μ μœΌλ‘œ μ•Œ 수 μžˆμ„κ±° κ°™λ‹€κ³  μƒκ°ν•΄μ„œ requestλ₯Ό μ‚¬μš©ν–ˆμŠ΅λ‹ˆλ‹€

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ κ·Έ λΆ€λΆ„ 말고 HttpStatusλΆ€λΆ„ λ§ν•œκ±°μ—μš”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ 그럼 createκ°€ 더 λ‚«κ² λ„€μš” μˆ˜μ •ν• κ²Œμš”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ecd26fe

μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€

Copy link
Member

@Umjiseung Umjiseung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€

@ta2ye0n ta2ye0n merged commit 1fe39a8 into develop Apr 5, 2024
1 check passed
@ta2ye0n ta2ye0n deleted the 37-book-order branch April 5, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

μ±… μ‹ μ²­ν•˜λŠ” api λ§Œλ“€μ–΄ λ³΄κ² μŠ΅λ‹ˆλ‹€
2 participants