Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing update for incremental models #42

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

alkm1g12
Copy link
Contributor

Add configuration to enable the user of the package to determine a window for filtered touches and filtered conversions where they are incremental models, e.g. 36 hours.

  • Applied to the two incremental base models for touches and conversions.
  • Checked compiled code for tests, and it successfully filters out older events.
  • Added new test events to check this works and filters to expected data

@alkm1g12 alkm1g12 requested a review from a team as a code owner September 12, 2024 12:31
Copy link
Contributor

@tomshelllby tomshelllby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

Copy link

@Zshyw Zshyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@alkm1g12 alkm1g12 merged commit 78f49cd into main Sep 12, 2024
1 check passed
@alkm1g12 alkm1g12 deleted the feature/test_incremental branch September 12, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants