Merged

Tapadoo · Apr 2, 2021 · 86e84e2 · 86e84e2
2 parents 9580c02 + cdeee38
commit 86e84e2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,9 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## 7.0.1 - 05/02/2021
+* updated navigation_bar height getter.
+
 ## 7.0.0 - 27/01/2021
 * Added support in Dialog.
 

diff --git a/alerter/src/main/java/com/tapadoo/alerter/Alert.kt b/alerter/src/main/java/com/tapadoo/alerter/Alert.kt
@@ -118,6 +118,11 @@ class Alert @JvmOverloads constructor(context: Context,
 
     val layoutContainer: View? by lazy { findViewById<View>(R.id.vAlertContentContainer) }
 
+    private val navigationBarHeight by lazy {
+        val dimenId = resources.getIdentifier("navigation_bar_height", "dimen", "android")
+        resources.getDimensionPixelSize(dimenId)
+    }
+
     init {
         inflate(context, R.layout.alerter_alert_view, this)
 
@@ -155,7 +160,7 @@ class Alert @JvmOverloads constructor(context: Context,
 
         (layoutParams as MarginLayoutParams).apply {
             if (layoutGravity != Gravity.TOP) {
-                bottomMargin = getDimenPixelSize(R.dimen.navigation_bar_height)
+                bottomMargin = navigationBarHeight
             }
         }
 

diff --git a/alerter/src/main/res/values/dimens.xml b/alerter/src/main/res/values/dimens.xml
@@ -23,7 +23,4 @@
     <dimen name="alerter_text_medium">18sp</dimen>
     <dimen name="alerter_alert_view_padding_top">70dp</dimen>
 
-    <!--Display sizes-->
-    <dimen name="navigation_bar_height">48dp</dimen>
-
 </resources>