Skip to content

Commit

Permalink
Hot fix
Browse files Browse the repository at this point in the history
ui overlapp
npe check added for amounted currency
  • Loading branch information
AhlaamK-tap committed May 14, 2023
1 parent 2e659fc commit 66f94bc
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .idea/deploymentTargetDropDown.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
# CHANGELOG
[3.16.3] - 2023-05-14
### Hot Fix:
- Bug fix for UI
### Impact on existing integrations:
- The update does not impact existing integrations.
### Recommended changes for existing integrations before updating:
- None.
[3.16.2] - 2023-04-04
### Hot Fix:
- Bug fix for NPE
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ To integrate goSellSDK into your project add it in your **root** `build.gradle`
Step 2. Add the dependency
```java
dependencies {
implementation 'com.github.Tap-Payments:goSellSDK-AndroidX:3.16.2'
implementation 'com.github.Tap-Payments:goSellSDK-AndroidX:3.16.3'
}
```

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -336,11 +336,12 @@ private void setupChargeOrAuthorizeMode() {

}else {

if (dataSource.getSelectedCurrency() != null)
if (dataSource.getSelectedCurrency() != null && dataSource.getSelectedCurrency().getAmount()!=null && dataSource.getSelectedCurrency().getAmount()!=null ){
payButton.getPayButton().setText(String
.format("%s %s %s", getResources().getString(R.string.pay),
dataSource.getSelectedCurrency().getSymbol(),
dataSource.getSelectedCurrency().getAmount()));
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ private AmountedCurrency getTransactionCurrency() {

String currencyCode = paymentOptionsResponse.getCurrency();

if(paymentOptionsResponse!=null && paymentOptionsResponse.getSupportedCurrencies()!=null)
for (AmountedCurrency amountedCurrency : paymentOptionsResponse.getSupportedCurrencies()) {

if (amountedCurrency.getCurrency().equals(currencyCode)) return amountedCurrency;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -323,10 +323,10 @@
android:layout_marginTop="18dp"
android:layout_marginBottom="18dp"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintLeft_toLeftOf="parent"
app:layout_constraintEnd_toStartOf="@+id/saveCardSwitch"
android:layout_marginEnd="@dimen/margin_basic_16dp"
app:layout_constraintTop_toBottomOf="@id/saveCardTopSeparator"
app:layout_constraintBottom_toBottomOf="parent"

android:text="@string/textview_disclaimer_save_card"
android:textDirection="locale"
/>
Expand Down

0 comments on commit 66f94bc

Please sign in to comment.