Enhancement Feature

The merchant can now configure the scanner to be shown or hide
Tap-Payments · May 24, 2023 · 30e9a19 · 30e9a19
1 parent 4361ed9
commit 30e9a19
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,11 @@
 # CHANGELOG
+[3.17.0] - 2023-05-24
+### Enhancement Feature:
+- The merchant can now configure the scanner to be shown or hide
+### Impact on existing integrations:
+- The update does not impact existing integrations.
+### Recommended changes for existing integrations before updating:
+- None.
 [3.16.4] - 2023-05-22
 ### Hot Fix:
 - bug fix for text

diff --git a/README.md b/README.md
@@ -352,6 +352,8 @@ import company.tap.gosellapi.GoSellSDK
           // change scan icon
           .setScanIconDrawable(getResources().getDrawable(R.drawable.btn_card_scanner_normal)) // **Optional**
 
+          //Show or hide the scanner
+         .setCardScannerIconVisible(true) // **Optional**
           // setup pay button selector [ background - round corner ]
           .setPayButtonResourceId(R.drawable.btn_pay_selector)
 
@@ -434,7 +436,9 @@ import company.tap.gosellapi.GoSellSDK
 
           // change scan icon
           .setScanIconDrawable(getResources().getDrawable(R.drawable.btn_card_scanner_normal)) // **Optional**
-
+
+              //Show or hide the scanner
+              .setCardScannerIconVisible(true) // **Optional**
           // setup pay button selector [ background - round corner ]
           .setPayButtonResourceId(R.drawable.btn_pay_selector)
 

diff --git a/goSellSDKSample/src/main/java/company/tap/sample/activity/MainActivity.java b/goSellSDKSample/src/main/java/company/tap/sample/activity/MainActivity.java
@@ -184,6 +184,7 @@ private void configureSDKThemeObject() {
                 .setSaveCardSwitchOnTrackTint(getResources().getColor(R.color.vibrant_green_pressed))
 
                 .setScanIconDrawable(getResources().getDrawable(R.drawable.btn_card_scanner_normal))
+                .setCardScannerIconVisible(true) // **Optional**
 
                 .setPayButtonResourceId(R.drawable.btn_pay_selector)  //btn_pay_merchant_selector
                 .setPayButtonFont(Typeface.createFromAsset(getAssets(), "fonts/roboto_light.ttf"))
@@ -193,7 +194,8 @@ private void configureSDKThemeObject() {
                 .setPayButtonTextSize(14)
                 .setPayButtonLoaderVisible(true)
                 .setPayButtonSecurityIconVisible(true)
-                .setPayButtonText("Tokenize Text value") // **Optional**
+               // .setPayButtonText("Tokenize Text value") // **Optional**
+
 
 
                 // setup dialog textcolor and textsize

diff --git a/...y/src/main/java/company/tap/gosellapi/internal/viewholders/CardCredentialsViewHolder.java b/...y/src/main/java/company/tap/gosellapi/internal/viewholders/CardCredentialsViewHolder.java
@@ -270,6 +270,11 @@ public void afterTextChanged(Editable s) {
 
           cardScannerButton = itemView.findViewById(R.id.cardScannerButton);
 
+        if(ThemeObject.getInstance().isSetCardScannerIconVisible()) cardScannerButton.setVisibility(View.VISIBLE);
+        else cardScannerButton.setVisibility(View.GONE);
+
+
+
 /////////////////////////////////////////////////// CARD EXPIRATION_DATE START ///////////////////////////////////////////////////////
         expirationDateField = itemView.findViewById(R.id.expirationDateField);
         // enable Expiration date dialog

diff --git a/library/src/main/java/company/tap/gosellapi/open/controllers/ThemeObject.java b/library/src/main/java/company/tap/gosellapi/open/controllers/ThemeObject.java
@@ -48,7 +48,7 @@ public class ThemeObject {
         private int                     saveCardSwitchOffTrackTint;
         private int                     saveCardSwitchOnTrackTint;
         private Drawable                scanIconDrawable;
-
+        private boolean                 cardScannerIconVisible=true;
 
         /**
          *  Tap Button
@@ -346,6 +346,14 @@ public ThemeObject setPayButtonSecurityIconVisible(boolean payButtSecurityIconVi
                 return this;
         }
 
+        /**
+         * pay button view or hide scanner
+         * @param cardScannerIconVisible
+         */
+        public ThemeObject setCardScannerIconVisible(boolean cardScannerIconVisible) {
+                this.cardScannerIconVisible = cardScannerIconVisible;
+                return this;
+        }
         /**
          *
          * @param payButtLoaderVisible
@@ -573,6 +581,13 @@ public boolean isPayButtSecurityIconVisible() {
                 return this.payButtSecurityIconVisible;
         }
 
+        /**
+         * @return pay button security icon visible
+         */
+        public boolean isSetCardScannerIconVisible() {
+                return this.cardScannerIconVisible;
+        }
+
         /**
          *
          * @return