[bug fix] Step retries for max retry even if step state is not error #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step would retry for all errors for MaxRunAttempts even when step moved out of Error State.
Cause
shouldRetry
returns true ifstep.StepOpts.RetryAllErrors
is set to true, without checking ifstep.stepResult.StepState
is in Error state.Fix
step.stepResult.StepState
to be StepStateError in addition to the RetryAllErrors fixes this bug.In addition
step.StepOpts.MaxRunAttempts == step.stepRunProgress.runCount
has been removed fromshouldExit
This pull request includes changes to the
go_steps.go
file to enhance the retry and exit logic for steps. The most important changes include adding a condition to check the step state before retrying and refactoring the exit logic to use a switch statement.Enhancements to retry logic:
go_steps.go
: Updated theshouldRetry
method to include a condition that checks if the step state isStepStateError
before retrying.Refactoring exit logic:
go_steps.go
: Refactored theshouldExit
method to use a switch statement for better readability and removed the redundant return statement.