[bug fix] step retries for max retry even if step state is not error

TanmoySG · Nov 7, 2024 · 610edd7 · 610edd7
1 parent 3833669
commit 610edd7
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/go_steps.go b/go_steps.go
@@ -139,7 +139,7 @@ func (step *Step) shouldRetry() bool {
 		return true
 	}
 
-	if step.StepOpts.RetryAllErrors {
+	if step.stepResult.StepState == StepStateError && step.StepOpts.RetryAllErrors {
 		return true
 	}
 
@@ -161,14 +161,10 @@ func (step *Step) shouldExit() bool {
 		return false
 	}
 
-	if step.StepOpts.MaxRunAttempts == step.stepRunProgress.runCount {
-		switch step.stepResult.StepState {
-		case StepStateComplete, StepStateSkipped:
-			return false
-		default: // StepStateError, StepStatePending, StepStateFailed
-			return true
-		}
+	switch step.stepResult.StepState {
+	case StepStateComplete, StepStateSkipped:
+		return false
+	default: // StepStateError, StepStatePending, StepStateFailed
+		return true
 	}
-
-	return false
 }