Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): downgrade vite-plugin-dts #164

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Sep 16, 2024

Fixes build-only type issues in TanStack Router repo. For example, @tanstack/start-vite-plugin:

vite-plugin-dts 4.1.0:

vite v5.4.5 building for production...
src/index.ts:3:15 - error TS2305: Module '"../../../node_modules/vite/index.cjs"' has no exported member 'Plugin'.

3 import type { Plugin } from 'vite'
                ~~~~~~
src/index.ts:17:22 - error TS7006: Parameter 'config' implicitly has an 'any' type.

17     configResolved: (config) => {
                        ~~~~~~
src/index.ts:20:15 - error TS7006: Parameter 'code' implicitly has an 'any' type.

20     transform(code, id) {
                 ~~~~
src/index.ts:20:21 - error TS7006: Parameter 'id' implicitly has an 'any' type.

20     transform(code, id) {
                       ~~

Please fix the above type errors
 ELIFECYCLE  Command failed with exit code 1.

vite-plugin-dts 4.0.3:

vite v5.4.5 building for production...
✓ 3 modules transformed.

[vite:dts] Start generate declaration files...

[vite:dts] Start generate declaration files... (x2)
dist/esm/ast.js        0.82 kB │ gzip: 0.34 kB │ map: 1.48 kB
dist/esm/index.js      1.74 kB │ gzip: 0.71 kB │ map: 2.76 kB
dist/esm/compilers.js  4.33 kB │ gzip: 1.16 kB │ map: 8.33 kB
[vite:dts] Declaration files built in 1804ms.

[vite:dts] Declaration files built in 790ms.

dist/cjs/ast.cjs        1.44 kB │ gzip: 0.59 kB │ map: 1.51 kB
dist/cjs/index.cjs      1.88 kB │ gzip: 0.77 kB │ map: 2.84 kB
dist/cjs/compilers.cjs  5.37 kB │ gzip: 1.41 kB │ map: 8.42 kB
✓ built in 1.90s

Copy link

pkg-pr-new bot commented Sep 16, 2024

pnpm add https://pkg.pr.new/@tanstack/config@164

commit: 7d6fac8

Copy link

nx-cloud bot commented Sep 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7d6fac8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@lachlancollins lachlancollins merged commit 9089880 into main Sep 16, 2024
5 checks passed
@lachlancollins lachlancollins deleted the downgrade-vite-plugin-dts branch September 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant