Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expected errors spamming sentry #1514

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: expected errors spamming sentry #1514

wants to merge 2 commits into from

Conversation

@alecdwm alecdwm requested a review from 0xKheops July 4, 2024 13:15
@alecdwm alecdwm added the bug A bug label Jul 4, 2024
@alecdwm alecdwm enabled auto-merge (squash) July 4, 2024 13:15
Copy link
Contributor

github-actions bot commented Jul 4, 2024

💥 No changeset(s) detected

This PR is missing changesets for the following packages:

"extension-core"

Please add a changeset for these packages.
You can do so by running yarn changeset in your local development environment.

Not sure what this means? Click here to learn what changesets are.

Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this method of doing this
Our sentry config already comes with an array of ignoreErrors regexes. I think it's preferably to continue with that method rather than creating a new way of doing something similar.

@chidg chidg disabled auto-merge July 5, 2024 02:42
@alecdwm
Copy link
Member Author

alecdwm commented Jul 23, 2024

Not sure about this method of doing this Our sentry config already comes with an array of ignoreErrors regexes. I think it's preferably to continue with that method rather than creating a new way of doing something similar.

Yeah, that definitely makes sense!
I do wish there was a better built-in way for sentry exclusions than just regex matching on the error message. I'm a big fan of these instanceof checks 😭
But you're right they're not worth the cost of yet another method to exclude errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants