Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Talisman hostname check for portal url #1117

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix Talisman hostname check for portal url #1117

merged 1 commit into from
Oct 10, 2023

Conversation

chidg
Copy link
Contributor

@chidg chidg commented Oct 10, 2023

No description provided.

@chidg chidg enabled auto-merge (squash) October 10, 2023 03:00
@chidg chidg requested a review from 0xKheops October 10, 2023 03:00
0xKheops
0xKheops approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@0xKheops 0xKheops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chidg chidg merged commit 4cabbfd into dev Oct 10, 2023
4 checks passed
@chidg chidg deleted the fix/talisman-hostname-check-for-portal branch October 10, 2023 03:03
chidg added a commit that referenced this pull request Oct 10, 2023
@chidg
Revert "fix: talisman hostname check for portal url (#1117)"
0f9ca5f 
This reverts commit 4cabbfd.
@chidg chidg mentioned this pull request Oct 10, 2023
Merged
chidg added a commit that referenced this pull request Oct 10, 2023
@chidg
Revert "fix: talisman hostname check for portal url (#1117)" (#1118)
97f2b5f 
This reverts commit 4cabbfd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xKheops 0xKheops 0xKheops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chidg @0xKheops