Minor code simplifications #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovalseven8
commented
Jun 18, 2019
| @@ -58,7 +58,6 @@ | |||
| private OkHostnameVerifier() { | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
To ensure compatibility with Java 1.5 (@Override is not allowed for implementations of interface methods).
ovalseven8
commented
Jun 18, 2019
| @@ -1199,15 +1198,17 @@ else if (frame.isContinuationFrame() == false) | |||
|
|
|||
| // Generate the first frame using the existing WebSocketFrame instance. | |||
| // Note that the reserved bit 1 and the opcode are untouched. | |||
| byte[] payload = Arrays.copyOf(originalPayload, maxPayloadSize); | |||
There was a problem hiding this comment.
Arrays.copyOf() is not available in Java 1.5 that is targeted by this library.
ovalseven8
commented
Jun 18, 2019
| frame.setFin(false).setPayload(payload); | ||
| frames.add(frame); | ||
|
|
||
| for (int from = maxPayloadSize; from < originalPayload.length; from += maxPayloadSize) | ||
| { | ||
| // Prepare the payload of the next continuation frame. | ||
| int to = Math.min(from + maxPayloadSize, originalPayload.length); | ||
| payload = Arrays.copyOfRange(originalPayload, from, to); |
There was a problem hiding this comment.
Arrays.copyOfRange() is not available in Java 1.5 that is targeted by this library.
ovalseven8
commented
Jun 18, 2019
| "[%s] Bad code length '%d' at the bit index '%d'.", | ||
| DeflateUtil.class.getSimpleName(), codeLength, bitIndex); | ||
| "[%s] Bad code length '%d' at the bit index '%s'.", | ||
| DeflateUtil.class.getSimpleName(), codeLength, Arrays.toString(bitIndex)); |
There was a problem hiding this comment.
Exception at runtime possible otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.