Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vscode): add useVSCodeProxy option to control whether to use Vscode Proxy #3440

Merged
merged 8 commits into from
Nov 22, 2024
Merged

chore(vscode): add useVSCodeProxy option to control whether to use Vscode Proxy #3440

merged 8 commits into from
Nov 22, 2024

Conversation

antimonyGu
Copy link
Contributor

@antimonyGu antimonyGu commented Nov 19, 2024 •
edited
Loading

Test

  • Setting
    "tabby.settings.advanced": {
        "useVSCodeProxy": false
    },

, proxy.url will be ""(empty string).

    "tabby.settings.advanced": {
        "useVSCodeProxy": true
    },

, proxy.url will be "http://localhost:9000".

close #3360

icycodes
icycodes requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@icycodes icycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description.

@wsxiaoys wsxiaoys changed the title fix(vscode): check weather proxy url is in noProxy field chore(vscode): add useVSCodeProxy option to control whether to use Vscode Proxy Nov 21, 2024
@wsxiaoys wsxiaoys merged commit b920edd into TabbyML:main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icycodes icycodes icycodes approved these changes

@wsxiaoys wsxiaoys wsxiaoys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The proxy server in vscode settings, blocks access to tabby on localhost
3 participants
@antimonyGu @wsxiaoys @icycodes