Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Add functional tests for showAction #1419

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[TASK] Add functional tests for showAction #1419

wants to merge 4 commits into from

Conversation

Starkmann
Copy link
Collaborator

@Starkmann Starkmann commented Jul 31, 2024 •
edited by oliverklee
Loading

Fixes #1228

@Starkmann Starkmann added this to the 4.0.0: Breaking changes milestone Jul 31, 2024
@Starkmann Starkmann requested a review from oliverklee July 31, 2024 12:33
@coveralls
Copy link

coveralls commented Jul 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10185208360

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10184249487: 0.0%
Covered Lines: 46
Relevant Lines: 46
💛 - Coveralls

@oliverklee oliverklee changed the title [TASK] Add for showAction [TASK] Add functional tests for showAction Jul 31, 2024
oliverklee
oliverklee requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test generally looks good. There are some style warnings, though, and the branch needs a rebase.

Also, I'd prefer a cleaner solution over disabling cHash validation.

Tests/Functional/Controller/TeaControllerTest.php Outdated Show resolved Hide resolved
Tests/Functional/Controller/TeaControllerTest.php Outdated Show resolved Hide resolved
@Starkmann Starkmann force-pushed the tests/functionalShowAction branch from 63f4f16 to 8ac9240 Compare July 31, 2024 17:40
@oliverklee oliverklee force-pushed the tests/functionalShowAction branch from 951aaf0 to 647edec Compare December 24, 2024 10:01
oliverklee
oliverklee requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to have a look at the lowest test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Starkmann Starkmann

Labels
setup functional tests for requests
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.

Add a functional test for the Tea single view
3 participants
@Starkmann @coveralls @oliverklee