Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Move php-cs-fixer to Build dir #1353

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[TASK] Move php-cs-fixer to Build dir #1353

wants to merge 5 commits into from

Conversation

lukaszuznanski
Copy link
Contributor

Part of: #1186

oliverklee
oliverklee requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the .gitattributes to no longer exclude the file anymore (as we already exclude Build/).

composer.json Outdated Show resolved Hide resolved
@lukaszuznanski lukaszuznanski force-pushed the TASK/Move-php-cs-fixer-to-build-dir branch from a4b29b7 to 81cb617 Compare July 7, 2024 22:00
@lukaszuznanski lukaszuznanski requested a review from oliverklee July 7, 2024 22:01
@lukaszuznanski lukaszuznanski self-assigned this Jul 7, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Jul 8, 2024
oliverklee
oliverklee requested changes Jul 8, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
oliverklee
oliverklee requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to adapt the prepare-release Composer script.

@lukaszuznanski lukaszuznanski force-pushed the TASK/Move-php-cs-fixer-to-build-dir branch from 81cb617 to e2ad2f6 Compare September 17, 2024 10:50
@oliverklee oliverklee changed the title [TASK] Move php-cs-fixer to build dir [TASK] Move php-cs-fixer to Build dir Sep 17, 2024
oliverklee
oliverklee requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to include the Build folder to be processed by PHP-CS-Fixer and PHP_CodeSniffer now.

composer.json Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10903393754

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10903110277: 0.0%
Covered Lines: 67
Relevant Lines: 67
💛 - Coveralls

@lukaszuznanski lukaszuznanski force-pushed the TASK/Move-php-cs-fixer-to-build-dir branch from 8fecb3e to 573cc0e Compare September 17, 2024 12:49
oliverklee
oliverklee requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to add Build to the files that PHP-CS-Fixer and PHP_CodeSniffer check.

oliverklee
oliverklee reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to add Build/ to the list of directories that get stylechecked/fixed by PHP_CodeSniffer and PHP-CS-Fixer.

Also, could you please resolve the merge conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@lukaszuznanski lukaszuznanski

Labels
make the extension conform to the best practices
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszuznanski @coveralls @oliverklee