-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all tooling configuration to Build dir #1202
base: main
Are you sure you want to change the base?
Move all tooling configuration to Build dir #1202
Conversation
I think this deserves an entry in the changelog. What do you think? |
@sbuerk provided some more feedback and recommends to not use |
Ok, I'm not sure if this was decided, can't find it in meeting minutes |
@oliverklee @sbuerk should we use |
If you ask me, yes. That's also the folder the TYPO3 core uses for these things of tool configurations (with sub-folders per tool) and core merger/contributors adopted for extensions and projects. I talked with @oliverklee and @DanielSiepmann on that already. In the end, it's about naming with some requirements:
There are other preferences, which you should discuss/define within the team first I guess. For example stying on the root-folder / default naming. Personally, |
6f0be0f
to
b6bb438
Compare
Pull Request Test Coverage Report for Build 9165103416Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I propose we split this PR up into "one tool per PR". This makes the reviews easier, reduces the risk of us missing things, and helps get the changes merged faster. |
Resolve: #1186