Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Adjust mount point indexing #4195

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[TASK] Adjust mount point indexing #4195

wants to merge 3 commits into from

Commits on Dec 2, 2024

  1. [TASK] Clean and improve ConnectionManagerTest 

    Fixtures of ConnectionManagerTest were not yet updated
and included basic configuration that can be provided
automatically, this commit cleans the fixtures and
enables the automatic provision.
    @dkd-friedrich
    dkd-friedrich committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    4a74cdc View commit details
    Browse the repository at this point in the history

  2. [TASK] Adjust mount point indexing 

    Mount point indexing and corresponding tests have been adjusted for
TYPO3 13. Mount points are supported in general and the mounted pages
will be indexed like standard pages.

But there is a point to consider: Mounted pages from a pagetree
without a site configuration cannot be indexed, in fact TYPO3
currently can't mount a page from a page tree without a site
configuration and an exeception occurs.

Test procedure in PageIndexerTest has been improved and now uses
the PageUriBuilder to build the url to index, instead of building
the url in the test itself.

Resolves: TYPO3-Solr#4160
    @dkd-friedrich
    dkd-friedrich committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c36efc4 View commit details
    Browse the repository at this point in the history

  3. [BUGFIX] Fix record monitoring if site is missing 

    Updates of records or pages lead to an SiteNotFoundException if
no site is configured. This is caused by the GarbageHandler and/or
DataUpdateHandler.

This issue is fixed by adding additional checks, skipping the
monitoring is save as change are not relevant for solr if no site
is present, this includes mount pages as TYPO3 cannot mount pages
outside of a configured site.

Relates: 4160
    @dkd-friedrich
    dkd-friedrich committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    a2fb66f View commit details
    Browse the repository at this point in the history