-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller用のテストutilを作成 #47
Draft
oginoshikibu
wants to merge
26
commits into
develop
Choose a base branch
from
feat/controller_test
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
実装完了
元ブランチがmergeされ次第rebaseしてopenする
Close #48
概要
Controllerのテストの実装方法について調査し、一例と中身を実装する
変更点
詳細
Controllerのテストは一般的なGoのUnitテストのような、入出力制御では不可能である。そのため、リクエストを作成し、それを入力として与えて得たレスポンスを比較することで可能となる
ref: ginをMVCで設計している時にコントローラのテストを書く
どのようなcontrollerでも同様な手順であると想定されるため、その部分を
testutils
というpackageに切り出し、あたかも通常のunit testのように、table driven testの形式で書けるようにした。また、
testutils
パッケージがutils
フォルダ内に含まれているが、今後utils
パッケージは作成せずに内部に個別パッケージを作成する方針にしたい。未実施事項
特になし
その他
特になし