#220 [Refactor] 제안서 상세보기 API Controller, Service 분리 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KWY0218
reviewed
Feb 1, 2024
Comment on lines
69
to
72
| List<Boolean> preferOfferConditionBooleanList = Arrays.stream(OfferCondition.values()).map(condition -> { | ||
| if (offerConditionList.contains(condition)) return true; | ||
| else return false; | ||
| }).collect(Collectors.toList()); |
There was a problem hiding this comment.
Suggested change
| List<Boolean> preferOfferConditionBooleanList = Arrays.stream(OfferCondition.values()).map(condition -> { | |
| if (offerConditionList.contains(condition)) return true; | |
| else return false; | |
| }).collect(Collectors.toList()); | |
| List<Boolean> preferOfferConditionBooleanList = Arrays.stream(OfferCondition.values()).map(offerConditionList::contains).collect(Collectors.toList()); |
p2
contains 자체가 boolean을 반환하기 때문에 함다를 사용하여 위 코드 처럼 코드를 줄일 수 있을 것 같습니다
| return new DesignerInfoOpenChatDto(designer.getKakaoOpenChatUrl(),designer.getProfileImgUrl(), designer.getHairShop().getName(), designer.getName(), designer.getIntroduction()); | ||
| List<String> dayOfWeekList = getDayOfWeekList(designerId); | ||
|
|
||
| DesignerInfoResponse designerInfoResponse = new DesignerInfoResponse(designer.getProfileImgUrl(), designer.getHairShop().getName(), designer.getName(), designer.getPortfolio().getInstagramUrl(), designer.getPortfolio().getNaverPlaceUrl(), designer.getIntroduction(), designer.getGender().getValue(), dayOfWeekList, designer.getHairShop().getAddress(), designer.getHairShop().getDetailAddress()); |
There was a problem hiding this comment.
p4
해당 객체와 같이 생성자가 많은 dto인 경우에는 builder를 사용하는 것이 좋다고 생각합니다..!
어떻게 생각하시나요?
There was a problem hiding this comment.
@KWY0218 저도 그부분 고민을 했는데 파라미터 값들이 많아서 Builder 사용이 좋을것 같네요! :) 🫡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?