[refactor] 카카오 오픈채팅 api service 분리 #212

pkl0912 · 2024-01-30T07:15:00Z

해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)

1h~2h

해결하려는 문제가 무엇인가요?

카카오 오픈채팅 로직 service 분리

어떻게 해결했나요?

applicationUrl 외에 다른 건 다 designer관련입니다!
근데 offerId 로 application, designer 를 찾는 로직입니다

KWY0218

작업하시느라 고생하셨습니다!
코맨트 확인해주세요!

KWY0218 · 2024-01-30T07:21:08Z

src/main/java/com/moddy/server/controller/model/ModelController.java

@@ -39,6 +40,7 @@
 public class ModelController {

    private final ModelService modelService;
+    private final ModelRetrieveService modelRetrieveService;


p2
현재 ModelController이긴 하지만 해당 API는 OfferController의 성격을 띄고 있습니다.
비록 현재 라우터는 /model/{offerId}/agress 이지만, 이는 추후에 수정할 예정이기 때문에
지금은 어색하더라도 ModelRetrieveService가 아닌 OfferRetrieveService를 통해 정보를 가져오는 것이 좋을 것 같습니다

KWY0218 · 2024-01-30T07:28:22Z

src/main/java/com/moddy/server/service/model/ModelRetrieveService.java

+@Service
+@RequiredArgsConstructor
+@Transactional(readOnly = true)
+public class ModelRetrieveService {


p2
ModelRetrieveService 가 아닌 OfferRetrieveService 라고 생각하고 리뷰 달겠습니다!

KWY0218 · 2024-01-30T07:29:28Z

src/main/java/com/moddy/server/service/model/ModelRetrieveService.java

+        Long designerId = hairServiceOfferRetrieveService.getDesignerApplicationId(offerId).designerId();
+        Long applicationId = hairServiceOfferRetrieveService.getDesignerApplicationId(offerId).applicationId();


p1
우선 Offer 엔티티는 designerId와 applicationId를 외래키로 가지고 있습니다.
그래서 각 도메인의 retrieve 서비스를 이용하지 않아도
offerRepository를 통해서 해당 Offer를 가져온다면 designerId와 applicationId를 가지고 올 수 있습니다.

KWY0218 · 2024-01-30T07:32:27Z

src/main/java/com/moddy/server/service/designer/DesignerRetrieveService.java

+    public DesignerInfoOpenChatDTO getDesignerOpenDetail(final Long userId){
+        Designer designer = designerJpaRepository.findById(userId).orElseThrow(() -> new NotFoundException(ErrorCode.DESIGNER_NOT_FOUND_EXCEPTION));
+        return new DesignerInfoOpenChatDTO(designer.getKakaoOpenChatUrl(),designer.getProfileImgUrl(), designer.getHairShop().getName(), designer.getName(), designer.getIntroduction());
+    }


KWY0218 · 2024-01-30T07:41:01Z

src/main/java/com/moddy/server/service/model/ModelRetrieveService.java

+        Long designerId = hairServiceOfferRetrieveService.getDesignerApplicationId(offerId).designerId();
+        Long applicationId = hairServiceOfferRetrieveService.getDesignerApplicationId(offerId).applicationId();
+
+        OpenChatResponse openChatResponse = new OpenChatResponse(hairModelApplicationRetrieveService.getApplicationCaptureUrl(applicationId), designerRetrieveService.getDesignerOpenDetail(designerId).kakaoUrl(), designerRetrieveService.getDesignerOpenChatDetail(designerId));


p2
applicationRetreieveService를 통해서 applicationCaptureUrl을 가져온 것은 좋습니다.
designerResponse를 반환할 때 designerRetrieveService에서 하는 것이 아닌 해당 로직에서 하는 것은 어떠나요?

아래 suggestion 코드의 변수 네이밍은 임의로 정한 것입니다! 코드를 반영하실 땐 적절한 네이밍으로 작성해주세요!

Suggested change

OpenChatResponse openChatResponse = new OpenChatResponse(hairModelApplicationRetrieveService.getApplicationCaptureUrl(applicationId), designerRetrieveService.getDesignerOpenDetail(designerId).kakaoUrl(), designerRetrieveService.getDesignerOpenChatDetail(designerId));

String applicationCaptureUrl = hairModelApplicationRetrieveService.getApplicationCaptureUrl(applicationId);

DesignerInfoOpenChatDTO dto = designerRetrieveService.getDesignerOpenDetail(designerId);

DesignerInfoOpenChatResponse response = new DesignerInfoOpenChatResponse(dto.imgUrl(), dto.shopName(), dto.name(), dto.introduction())

OpenChatResponse openChatResponse = new OpenChatResponse(applicationCaptureUrl, dto.kakaoUrl(), response);

return openChatResponse;

KWY0218 · 2024-01-30T07:42:28Z

src/main/java/com/moddy/server/controller/model/dto/DesignerInfoOpenChatDTO.java

+
+public record DesignerInfoOpenChatDTO(
+        String kakaoUrl,


p2
앱잼 때 DTO가 아닌 Dto로 명시하기로 정한 걸로 기억하고 있습니다..!

…into refactor/#211

KWY0218

수정사항 변경하느라 고생하셨습니다!
자잘한 코맨트 확인해주세요!

KWY0218 · 2024-01-30T09:50:10Z

src/main/java/com/moddy/server/service/model/ModelRetrieveService.java

+@Service
+@RequiredArgsConstructor
+@Transactional(readOnly = true)
+public class ModelRetrieveService {


p2
사용하지 않는 파일은 제거해주세요!

KWY0218 · 2024-01-30T09:51:37Z

src/main/java/com/moddy/server/service/designer/DesignerRetrieveService.java

+    public DesignerInfoOpenChatDto getDesignerOpenDetail(final Long userId){
+        Designer designer = designerJpaRepository.findById(userId).orElseThrow(() -> new NotFoundException(ErrorCode.DESIGNER_NOT_FOUND_EXCEPTION));


p2
userId 보다 designerId로 하는 것이 더욱 명시적일 것 같습니다!

KWY0218 · 2024-01-30T09:54:09Z

src/main/java/com/moddy/server/service/offer/HairServiceOfferRetrieveService.java

+
+    public OpenChatResponse getOpenChatInfo(Long userId, Long offerId) {
+        HairServiceOffer hairServiceOffer = hairServiceOfferJpaRepository.findById(offerId).orElseThrow(() -> new NotFoundException(ErrorCode.NOT_FOUNT_OFFER_EXCEPTION));


p3
해당 파라메터에도 final 을 붙이면 좋을 것 같습니다

KWY0218 · 2024-01-30T09:54:39Z

src/main/java/com/moddy/server/service/model/ModelService.java

@@ -73,6 +74,7 @@ public class ModelService {
    private final HairServiceRecordJpaRepository hairServiceRecordJpaRepository;
    private final AuthService authService;
    private final S3Service s3Service;
+    private final DesignerRetrieveService designerRetrieveService;


p2
사용하지 않는 서비스는 제거해주세요!
+) import

KWY0218

굳 좋습니다~!

KWY0218 · 2024-01-30T10:21:49Z

@pkl0912
추가로!! 커밋할 때 앞에 #이슈번호 잊지 말아주세요!!

hellozo0

구우욷... 고생하셨습니다..!!!
Designer랑 Application의 이미지 캡쳐만 가져오는데도 많은..파일 터치가 있네요.... 🫠

[refactor] service 분리

8b88fdd

pkl0912 added the refactor label Jan 30, 2024

pkl0912 added this to the 1차 리팩토링 기간 milestone Jan 30, 2024

pkl0912 requested review from hellozo0 and KWY0218 January 30, 2024 07:15

pkl0912 self-assigned this Jan 30, 2024

KWY0218 requested changes Jan 30, 2024

View reviewed changes

pkl0912 added 2 commits January 30, 2024 18:04

[refactor] ModelRetrieveService->OfferRetrieveService

db91657

Merge branch 'develop' of https://github.com/TEAM-MODDY/moddy-server …

a336ea6

…into refactor/#211

KWY0218 reviewed Jan 30, 2024

View reviewed changes

[refactor] 자잘한 오류 수정

9fefbda

KWY0218 approved these changes Jan 30, 2024

View reviewed changes

hellozo0 approved these changes Jan 30, 2024

View reviewed changes

pkl0912 merged commit 1002c00 into develop Jan 30, 2024
1 check passed

pkl0912 deleted the refactor/#211 branch January 30, 2024 12:48

KWY0218 removed this from the 1차 리팩토링 기간 milestone Jan 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[refactor] 카카오 오픈채팅 api service 분리 #212

[refactor] 카카오 오픈채팅 api service 분리 #212

pkl0912 commented Jan 30, 2024

KWY0218 left a comment

KWY0218 Jan 30, 2024

KWY0218 Jan 30, 2024

KWY0218 Jan 30, 2024

KWY0218 Jan 30, 2024

KWY0218 Jan 30, 2024

KWY0218 Jan 30, 2024

KWY0218 left a comment

KWY0218 Jan 30, 2024

KWY0218 Jan 30, 2024

KWY0218 Jan 30, 2024

KWY0218 Jan 30, 2024

KWY0218 left a comment

KWY0218 commented Jan 30, 2024

hellozo0 left a comment

		Long designerId = hairServiceOfferRetrieveService.getDesignerApplicationId(offerId).designerId();
		Long applicationId = hairServiceOfferRetrieveService.getDesignerApplicationId(offerId).applicationId();

-        OpenChatResponse openChatResponse = new OpenChatResponse(hairModelApplicationRetrieveService.getApplicationCaptureUrl(applicationId), designerRetrieveService.getDesignerOpenDetail(designerId).kakaoUrl(), designerRetrieveService.getDesignerOpenChatDetail(designerId));
+        String applicationCaptureUrl = hairModelApplicationRetrieveService.getApplicationCaptureUrl(applicationId);
+        DesignerInfoOpenChatDTO dto = designerRetrieveService.getDesignerOpenDetail(designerId);
+        DesignerInfoOpenChatResponse response = new DesignerInfoOpenChatResponse(dto.imgUrl(), dto.shopName(), dto.name(), dto.introduction())
+        OpenChatResponse openChatResponse = new OpenChatResponse(applicationCaptureUrl, dto.kakaoUrl(), response);
+        return openChatResponse;

		public DesignerInfoOpenChatDto getDesignerOpenDetail(final Long userId){
		Designer designer = designerJpaRepository.findById(userId).orElseThrow(() -> new NotFoundException(ErrorCode.DESIGNER_NOT_FOUND_EXCEPTION));


		public OpenChatResponse getOpenChatInfo(Long userId, Long offerId) {
		HairServiceOffer hairServiceOffer = hairServiceOfferJpaRepository.findById(offerId).orElseThrow(() -> new NotFoundException(ErrorCode.NOT_FOUNT_OFFER_EXCEPTION));

[refactor] 카카오 오픈채팅 api service 분리 #212

[refactor] 카카오 오픈채팅 api service 분리 #212

Conversation

pkl0912 commented Jan 30, 2024

관련 이슈번호

해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)

해결하려는 문제가 무엇인가요?

어떻게 해결했나요?

KWY0218 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KWY0218 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KWY0218 left a comment

Choose a reason for hiding this comment

KWY0218 commented Jan 30, 2024

hellozo0 left a comment

Choose a reason for hiding this comment