Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#137 [feat] erd user 에서 model로 수정 #139

Merged
merged 4 commits into from
Jan 16, 2024
Merged

#137 [feat] erd user 에서 model로 수정 #139

merged 4 commits into from
Jan 16, 2024

Conversation

KWY0218
Copy link
Member

@KWY0218 KWY0218 commented Jan 15, 2024

관련 이슈번호

해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)

  • 1h / 1h

해결하려는 문제가 무엇인가요?

  • 서비스 로직에서 model 의 구분이 잘 안됌
  • erd 의존성 높음

어떻게 해결했나요?

  • user 를 model로 전면 수정
before after
image image

@KWY0218 KWY0218 added the fix label Jan 15, 2024
@KWY0218 KWY0218 requested review from hellozo0 and pkl0912 January 15, 2024 18:05
@KWY0218 KWY0218 self-assigned this Jan 15, 2024
Copy link
Member

@hellozo0 hellozo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1:
Day off의 user_id -> designer_id로 변경해야할것 같은데 어떻게 생각하시나요???!!!

나머지는 하나하나 비교하느라 힘드셨을텐데... 고생하셨습니다 ㅠㅠ!!!
\강웡용 짱!!!!! 항상 감사드립니다...

Copy link
Member

@hellozo0 hellozo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

Copy link
Contributor

@pkl0912 pkl0912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 확인했습니다!!!

@KWY0218 KWY0218 merged commit a18e0b8 into develop Jan 16, 2024
1 check passed
@KWY0218 KWY0218 deleted the feat/#137 branch January 16, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] user id 에서 model id 로 외래키 지정하기
3 participants