Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/#104] 모델 회원가입 시 디폴트 이미지 저장 #113

Merged
merged 3 commits into from
Jan 12, 2024
Merged

[Feat/#104] 모델 회원가입 시 디폴트 이미지 저장 #113

merged 3 commits into from
Jan 12, 2024

Conversation

hellozo0
Copy link
Member

관련 이슈번호

해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)

  • 1h 걸렸습니다~

해결하려는 문제가 무엇인가요?

  • 모델이 처음 회원가입 시 디폴트 이미지를 가져와서 저장하는 로직을 구현했습니다~!

어떻게 해결했나요?

  • bucket은 secret으로 가려져셔 보여서 폴더명이랑, 파일이름은 상수로 관리하려고 써놨는데 이런 방법 써도 될까요?

@hellozo0 hellozo0 added the feat label Jan 12, 2024
@hellozo0 hellozo0 requested review from KWY0218 and pkl0912 January 12, 2024 13:39
@hellozo0 hellozo0 self-assigned this Jan 12, 2024
KWY0218
KWY0218 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@KWY0218 KWY0218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업하시느라 고생하셨습니다! 👍

pkl0912
pkl0912 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@pkl0912 pkl0912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@hellozo0 hellozo0 merged commit 2aa0dae into develop Jan 12, 2024
1 check passed
@hellozo0 hellozo0 deleted the feat/#104 branch January 12, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkl0912 pkl0912 pkl0912 approved these changes

@KWY0218 KWY0218 KWY0218 approved these changes

Assignees

@hellozo0 hellozo0

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 모델 생성 시 모델 default 이미지 적용 기능 구현
3 participants
@hellozo0 @KWY0218 @pkl0912