#110 [feat] offer 가 있으면 isSend true 기능 구현 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellozo0
approved these changes
Jan 12, 2024
| @@ -79,6 +80,11 @@ private Page<HairModelApplication> findApplications(int page, int size){ | |||
| return applicationPage; | |||
| } | |||
|
|
|||
| private Boolean getIsSend(Long applicationId, Long userId){ | |||
There was a problem hiding this comment.
p3:
함수명이 IsSend 보다는 상태값이라는 의미까지 더 넣어서 getSendStatus나 getIsSendStatus 면 더 이해하기 쉬울것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?