#105 [refactor] multipart/form을 file 과 json으로 분리 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KWY0218
reviewed
Jan 12, 2024
Comment on lines
17
to
18
| HairShop hairShop, | ||
| Portfolio portfolio, |
There was a problem hiding this comment.
p2
도메인을 바로 사용하는 것이 아닌 HairShopDto , PortfolioDto 만들어서 사용해주세요!
KWY0218
reviewed
Jan 12, 2024
| @@ -79,10 +75,11 @@ public SuccessResponse<List<RegionResponse>> getRegionList() { | |||
| @PostMapping(value = "/signup/designer", consumes = {MediaType.APPLICATION_JSON_VALUE, MediaType.MULTIPART_FORM_DATA_VALUE}) | |||
| SuccessResponse<UserCreateResponse> createDesigner( | |||
| @Parameter(hidden = true) @KakaoCode String kakaoCode, | |||
| @ModelAttribute DesignerCreateRequest request, | |||
| @RequestPart MultipartFile profileImg, | |||
| @RequestPart DesignerCreateRequest request, | |||
There was a problem hiding this comment.
p3
해당 부분을 request가 아닌 disignerInfo와 같은 변수명은 어떨까요?
added 2 commits
January 12, 2024 18:08
hellozo0
reviewed
Jan 12, 2024
Comment on lines
1
to
17
| package com.moddy.server.controller.designer.dto; | ||
|
|
||
| import lombok.*; | ||
|
|
||
| @Builder | ||
| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| @Getter | ||
| @ToString | ||
| public class HairShopDTO { | ||
|
|
||
| private String name; | ||
|
|
||
| private String address; | ||
|
|
||
| private String detailAddress; | ||
| } |
There was a problem hiding this comment.
p2 :
DTO Record가 아닌 class로 만든 이유가 있을까요??
| String introduction, | ||
| String kakaoOpenChatUrl, | ||
| List<DayOfWeek> dayOffs | ||
| List <DayOfWeek> dayOffs |
There was a problem hiding this comment.
p1 :
여기에 List 뒤에 뛰어쓰기가 하나 들어간것 같은데 확인해봐야 할것 같아요
Comment on lines
1
to
15
| package com.moddy.server.controller.designer.dto; | ||
|
|
||
| import lombok.*; | ||
|
|
||
| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| @Getter | ||
| @Builder | ||
| @ToString | ||
| public class PortfolioDTO { | ||
|
|
||
| private String instagramUrl; | ||
|
|
||
| private String naverPlaceUrl; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?