[Feat/#79] 모델 지원서 작성 API #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KWY0218
reviewed
Jan 11, 2024
Comment on lines
29
to
32
| public String uploadApplicationModelImage(MultipartFile multipartFile, Role role){ | ||
| return uploadImage(multipartFile, APPLICATION_PATH + "/" + role.name()); | ||
| } | ||
|
|
There was a problem hiding this comment.
p2
해당 함수를 사용하지 않아도 위 uploadProfileImage 함수를 사용하면 알아서 업로드 됩니다!
There was a problem hiding this comment.
아하 그렇군요! 혹시나 경로 더 나눠서 저장해야하는 줄 알고 만들었는데 기존 함수 쓰겠습니다~!
KWY0218
reviewed
Jan 11, 2024
Comment on lines
35
to
36
| private static final String ORIGIN = "origin"; | ||
|
|
There was a problem hiding this comment.
p2
해당 상수는 사용하지 않은 것 같아 보입니다..!
혹시 추가하신 이유가 있을까요?
There was a problem hiding this comment.
기존에 있길래 사용하긴 했는데요....... 삭제하겠습니다~!
KWY0218
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?