[Feat/#455] 공연 등록, 수정 변경사항 반영 #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
|
sinji2102
approved these changes
Dec 6, 2024
Comment on lines
+340
to
346
| return [ | ||
| ...posterUrls, | ||
| ...castUrls.filter((url) => url !== null), | ||
| ...staffUrls.filter((url) => url !== null), | ||
| ...performanceUrls, | ||
| ]; | ||
| }; |
| @@ -661,7 +670,7 @@ const ModifyManage = () => { | |||
| value={dataState.performanceDescription} | |||
| onChange={(e) => handleInputChange("performanceDescription", e.target.value)} | |||
| placeholder="공연을 예매할 예매자들에게 공연을 소개해주세요." | |||
| maxLength={500} | |||
| maxLength={1500} | |||
There was a problem hiding this comment.
p5) 근데 이거 서버에서 오케이 됏나요?? 회의 때 얘기햇던 거 같기도 하고... 기억안남이슈
There was a problem hiding this comment.
p5)
생각해보니까 여기 스크롤바 있는 게 좋을 거 같아서 디쟌에 한 번 물어봐야 할 거 같아요.... 아닌가 없는 게 낫나?... 물론 내용이 많아서 늘어나면 당연히 스크롤 사람들이 하긴 하겠지만 스크롤 되는 부분이라는 인지가 잘 안 되는 거 같아서!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
📸 스크린샷
🔗 참고 자료