Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable phase_center inputs to be SkyCoord #77

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

DanRyanIrish
Copy link
Contributor

This PR enables the phase_center inputs to the Visibilities calculating functions to be given as a SkyCoord. The result is that the Visibilities object knows its phase center in a valid coordinate frame, and hence enable imaging routines to return Maps in the same coordinate frame.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@ea833d9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
xrayvision/visibility.py 50.00% 7 Missing ⚠️
xrayvision/coordinates/frames.py 95.91% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage        ?   89.37%           
=======================================
  Files           ?        8           
  Lines           ?      969           
  Branches        ?        0           
=======================================
  Hits            ?      866           
  Misses          ?      103           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DanRyanIrish
Copy link
Contributor Author

Do not merge until #76 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant