-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] Update create vector #149
base: main
Are you sure you want to change the base?
Conversation
@nitro-neal is the intention to have this vector test an intermediate representation of a VC before it gets serialized as a JWT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an improvement so I will approve.
I think we should add additional vectors to verify that going from input -> VC -> VC JWT -> VC is a consistent process
As discussed: Every other test vector like corresponds to a function call: eg: every other one works in that you put the input and its like ‘known expected output’ Will create a new test vector |
@nitro-neal can this be closed? |
This updates the way create works:
The input are the fields for the actual input fields of a vc with the
VerifiableCredential.create()
method.The output is the comparison of the VcDataModel object to what is expected.
Note classes implementing this have can't JUST do an object to object comparison because certain things like id and issuance date will be different than the output (by design)
Example VerifiableCredential.create() vector: