Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change credentials create test vectors #139

Open
nitro-neal opened this issue Mar 22, 2024 · 2 comments · May be fixed by #149
Open

Change credentials create test vectors #139

nitro-neal opened this issue Mar 22, 2024 · 2 comments · May be fixed by #149
Assignees
@nitro-neal
Labels
pr-exists testing related to new or existing tests vc related to verifiable credentials

Comments

@nitro-neal
Copy link
Contributor

Currently the test vector uses .fromJson and only works in kotlin.

Need to change the test vector input so it's the input of VerifiableCredential.create() and works across all sdks

public fun <T> create(
  type: String,
  issuer: String,
  subject: String,
  data: T,
  credentialStatus: CredentialStatus? = null,
  issuanceDate: Date = Date(),
  expirationDate: Date? = null
): VerifiableCredential {
@nitro-neal nitro-neal self-assigned this Mar 22, 2024
@nitro-neal nitro-neal moved this to In Progress in SDK Development Apr 2, 2024
@nitro-neal
Copy link
Contributor Author

#149

@nitro-neal nitro-neal moved this from In Progress to In Code Review in SDK Development Apr 4, 2024
@decentralgabe decentralgabe added vc related to verifiable credentials testing related to new or existing tests labels Aug 16, 2024
@decentralgabe decentralgabe linked a pull request Aug 16, 2024 that will close this issue
[do not merge] Update create vector #149
Open
@decentralgabe
Copy link
Member

related to #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitro-neal nitro-neal

Labels
pr-exists testing related to new or existing tests vc related to verifiable credentials
Projects
SDK Development
Status: In Code Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[do not merge] Update create vector TBD54566975/web5-spec
2 participants
@nitro-neal @decentralgabe