Add credential schema #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
mistermoe,
tomdaffurn,
phoebe-lew,
diehuxx,
kirahsapong,
jiyoonie9 and
frankhinek
as code owners
This was referenced Apr 15, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 73.54% 73.58% +0.04%
==========================================
Files 45 45
Lines 2158 2162 +4
Branches 401 402 +1
==========================================
+ Hits 1587 1591 +4
Misses 376 376
Partials 195 195
|
decentralgabe
requested changes
Apr 15, 2024
| expirationDate = expirationCalendar.time, | ||
| data = KnownCustomerCredential(id = subjectDid.uri, country_of_residence = "US", tier = "Tier 1"), | ||
| credentialSchema = CredentialSchema( | ||
| id = "https://schema.org/PFI", |
There was a problem hiding this comment.
we should use a real schema here and update the verification logic to resolve and verify the json schema against the credential
There was a problem hiding this comment.
Verification pr will be coming next 👍
decentralgabe
approved these changes
Apr 15, 2024
jiyoonie9
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Credential Schema
A credential schema defines the structure and content of the data, enabling verifiers to assess if the data adheres to the established schema.
https://www.w3.org/TR/vc-data-model/#data-schemas