Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #206 #214

Closed
wants to merge 1 commit into from
Closed

Conversation

grahnj
Copy link

@grahnj grahnj commented Feb 2, 2024

Bye did:ion

Overview

Adds @Deprecated to DidIon

Description

Adds @Deprecated to DidIon

@phoebe-lew
Copy link
Contributor

As a part of this deprecation, we should probably not use DidIon in tests etc. either.

@mistermoe
Copy link
Member

Good point @phoebe-lew we can create a subsequent issue for that

Copy link
Member

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated!

@jiyoonie9 jiyoonie9 linked an issue Feb 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Merging #214 (763198a) into main (6ad5c2f) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   79.89%   79.89%           
=======================================
  Files          37       37           
  Lines        2169     2169           
  Branches      300      300           
=======================================
  Hits         1733     1733           
  Misses        297      297           
  Partials      139      139           
Components Coverage Δ
credentials 81.29% <ø> (ø)
crypto 38.07% <ø> (ø)
dids 89.71% <ø> (ø)
common 80.55% <ø> (ø)

@mistermoe
Copy link
Member

As a part of this deprecation, we should probably not use DidIon in tests etc. either.

tracking: #218

@jiyoonie9
Copy link
Contributor

update:

did:ion has been completely removed from dids package as part of this commit in a merged PR: 5f42234

also relevant comment #225 (comment)

@jiyoonie9 jiyoonie9 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mark DidIon as @Deprecated
4 participants