-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes various errors in the documentation #693
Conversation
fixes various doc mds more additions to docs more edits to docs
de420a9
to
979871f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! Couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
Comments replied to. Changes pushed.
you're welcome. happy to help. |
fixes various doc mds more additions to docs more edits to docs
…into bug/documentation
Overview
There's a handful of places in the docs that go to dead links or paths.
Description
Wanted to update those docs to help others in the future.
How Has This Been Tested?
Since this is a purely markdown and comment change, I didn't write tests. Please let me know if I need to do that, as I'm happy to do so.
Checklist
Tagging @decentralgabe @andresuribe87 since I've been communicating with them regarding these changes
Before submitting this PR, please make sure:
References
Docs changed:
pkg/middleware/Authentication.go
but the file for setting up auth is actuallypkg/server/middleware/authn.go
health check
andreadiness
api callsconfig.toml
file; I changed the language and linked it toconfig/dev.toml
AuthMiddleware
AuthMiddleware