Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hanging get traversal #176

Merged
merged 4 commits into from
Apr 11, 2024
Merged

fix hanging get traversal #176

merged 4 commits into from
Apr 11, 2024

Conversation

decentralgabe
Copy link
Member

gets were hanging for up to 15 minutes

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.04396% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 54.71%. Comparing base (f5a1022) to head (80e08f7).

Files Patch % Lines
impl/internal/dht/getput.go 64.58% 14 Missing and 3 partials ⚠️
impl/pkg/service/pkarr.go 39.28% 15 Missing and 2 partials ⚠️
impl/pkg/dht/logging.go 20.00% 4 Missing ⚠️
impl/cmd/cli/identity.go 0.00% 1 Missing ⚠️
impl/pkg/dht/dht.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   54.43%   54.71%   +0.28%     
==========================================
  Files          31       31              
  Lines        2370     2427      +57     
==========================================
+ Hits         1290     1328      +38     
- Misses        955      970      +15     
- Partials      125      129       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@decentralgabe decentralgabe marked this pull request as ready for review April 11, 2024 19:22
@decentralgabe decentralgabe merged commit 9eb197a into main Apr 11, 2024
8 checks passed
@decentralgabe decentralgabe deleted the fix-long-get branch April 11, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants