Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-GPR curation for EMP and Pentose and glucuronate interconversions #924

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JHL-452b
Copy link
Collaborator

@JHL-452b JHL-452b commented Nov 8, 2024

Main improvements in this PR:

As proposed in #877

  • Remove ENSG00000115425, ENSG00000116353 from MAR04591;
  • Remove ENSG00000198074 from MAR04592;
  • Remove ENSG00000115652 from MAR08729;
  • Remove ENSG00000180011, ENSG00000147576 from MAR03905;
  • Remove ENSG00000180011 from MAR04360;
  • Remove ENSG00000131482, ENSG00000141349 from MAR08652;
  • Remove ENSG00000184254 from MAR04283.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link

github-actions bot commented Nov 8, 2024

This PR has been automatically tested with GH Actions. Here is the output of the MACAW test:

Starting dead-end test...
- Found 1514 dead-end metabolites.
- Found 1319 reactions incapable of sustaining steady-state fluxes in either direction due to these dead-ends.
- Found 1977 reversible reactions that can only carry steady-state fluxes in a single direction due to dead-ends.
Starting duplicate test...
- Skipping redox duplicates because no redox_pairs and/or proton_ids were provided.
- Found 447 reactions that were some type of duplicate:
- 0 were completely identical to at least one other reaction.
- 13 involve the same metabolites but go in the opposite direction or have the opposite reversibility as at least one other reaction.
- 447 involve the same metabolites but with different coefficients as at least one other reaction.

This and a more detailed output from MACAW are also committed to data/macawResults/.

Note: In the case of multiple test runs, this post will be edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant