-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implements 2078, 2079 and 2080 #2205
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2205 +/- ##
========================================
Coverage 92.48% 92.48%
========================================
Files 91 91
Lines 2276 2276
Branches 673 673
========================================
Hits 2105 2105
Misses 171 171 ☔ View full report in Codecov by Sentry. |
@@ -1303,7 +1303,7 @@ | |||
"offchainDelayedOrderMinAge": "2", | |||
"offchainDelayedOrderMaxAge": "60", | |||
"maxLeverage": "27.5", | |||
"maxMarketValue": "5000", | |||
"maxMarketValue": "1000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XMR is not mentioned on any of the two SIPs
@@ -1303,7 +1303,7 @@ | |||
"offchainDelayedOrderMinAge": "2", | |||
"offchainDelayedOrderMaxAge": "60", | |||
"maxLeverage": "27.5", | |||
"maxMarketValue": "5000", | |||
"maxMarketValue": "1000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh yeah you are right leo, it has been already implemented but we never updated the repo https://sips.synthetix.io/sccp/sccp-2078/
No description provided.