Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements 2078, 2079 and 2080 #2205

Merged
merged 2 commits into from
Feb 23, 2024
Merged

implements 2078, 2079 and 2080 #2205

merged 2 commits into from
Feb 23, 2024

Conversation

kaleb-keny
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a3a109) 92.48% compared to head (982b8a6) 92.48%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2205   +/-   ##
========================================
  Coverage    92.48%   92.48%           
========================================
  Files           91       91           
  Lines         2276     2276           
  Branches       673      673           
========================================
  Hits          2105     2105           
  Misses         171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1303,7 +1303,7 @@
"offchainDelayedOrderMinAge": "2",
"offchainDelayedOrderMaxAge": "60",
"maxLeverage": "27.5",
"maxMarketValue": "5000",
"maxMarketValue": "1000",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XMR is not mentioned on any of the two SIPs

@@ -1303,7 +1303,7 @@
"offchainDelayedOrderMinAge": "2",
"offchainDelayedOrderMaxAge": "60",
"maxLeverage": "27.5",
"maxMarketValue": "5000",
"maxMarketValue": "1000",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh yeah you are right leo, it has been already implemented but we never updated the repo https://sips.synthetix.io/sccp/sccp-2078/

@kaleb-keny kaleb-keny changed the title implements 2079 and 2080 implements 2078, 2079 and 2080 Feb 20, 2024
@leomassazza leomassazza merged commit 90aeff1 into develop Feb 23, 2024
21 of 23 checks passed
@leomassazza leomassazza deleted the sccp-2079-2080 branch February 23, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants