pr review

Synthetixio · Oct 10, 2023 · b98b37f · b98b37f
1 parent bcd154a
commit b98b37f
Show file tree

Hide file tree

Showing 4 changed files with 78 additions and 52 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -35,24 +35,30 @@ jobs:
       image: ubuntu-2204:2022.04.1
       docker_layer_caching: true
     environment:
-      foundry_locked_commit: "232f66f9"
+      foundry_cache_version: "1"
     steps:
       - restore_cache:
           keys:
-            - foundry-bin-${foundry_locked_commit}-14
+            - foundry-bin-latest-${foundry_cache_version}
       - rust/install: {}
-      - run: |
-          if [ ! -d ~/.foundry ]; then
-            curl -L https://foundry.paradigm.xyz | bash
-            echo 'export PATH="$PATH:$HOME/.foundry/bin"' >> ~/.bashrc
-            source ~/.bashrc
-            foundryup
-          fi
-          rm -rf *
-          echo 'export PATH="$PATH:$HOME/.foundry/bin"' >> ~/.bashrc
-          source ~/.bashrc
+      - run: 
+            name: "Install Foundry"
+            working_directory: ~/
+            environment:
+              SHELL: /bin/bash
+            command: |-
+                export PATH="$PATH:$HOME/.foundry/bin"
+                echo 'export PATH=$PATH:$HOME/.foundry/bin' >> $BASH_ENV
+                if command -v anvil; then
+                  echo "Anvil already installed"
+                  anvil --version
+                else
+                  curl -L https://foundry.paradigm.xyz | bash
+                  foundryup
+                fi
+                rm -rf *
       - save_cache:
-          key: foundry-bin-${foundry_locked_commit}-14
+          key: foundry-bin-latest-${foundry_cache_version}
           paths:
             - ~/.foundry/bin
       - checkout
@@ -128,25 +134,31 @@ jobs:
       image: ubuntu-2204:2022.04.1
       docker_layer_caching: true
     environment:
-      foundry_locked_commit: "232f66f9"
+      foundry_cache_version: "1"
     resource_class: large
     steps:
       - restore_cache:
           keys:
-            - foundry-bin-${foundry_locked_commit}-14
+            - foundry-bin-latest-${foundry_cache_version}
       - rust/install: {}
-      - run: |
-          if [ ! -d ~/.foundry ]; then
-            curl -L https://foundry.paradigm.xyz | bash
-            echo 'export PATH="$PATH:$HOME/.foundry/bin"' >> ~/.bashrc
-            source ~/.bashrc
-            foundryup
-          fi
-          rm -rf *
-          echo 'export PATH="$PATH:$HOME/.foundry/bin"' >> ~/.bashrc
-          source ~/.bashrc
+      - run: 
+            name: "Install Foundry"
+            working_directory: ~/
+            environment:
+              SHELL: /bin/bash
+            command: |-
+                export PATH="$PATH:$HOME/.foundry/bin"
+                echo 'export PATH=$PATH:$HOME/.foundry/bin' >> $BASH_ENV
+                if command -v anvil; then
+                  echo "Anvil already installed"
+                  anvil --version
+                else
+                  curl -L https://foundry.paradigm.xyz | bash
+                  foundryup
+                fi
+                rm -rf *
       - save_cache:
-          key: foundry-bin-${foundry_locked_commit}-14
+          key: foundry-bin-latest-${foundry_cache_version}
           paths:
             - ~/.foundry/bin
       - checkout
@@ -294,7 +306,7 @@ jobs:
       image: ubuntu-2204:2022.04.1
       docker_layer_caching: true
     environment:
-      foundry_locked_commit: "232f66f9"
+      foundry_cache_version: "1"
     resource_class: large
     steps:
       - restore_cache:

diff --git a/.circleci/src/jobs/job-cannon.yml b/.circleci/src/jobs/job-cannon.yml
@@ -4,21 +4,28 @@ steps:
   # get foundry
   - restore_cache:
       keys:
-        - foundry-bin-${foundry_locked_commit}-14
+        - foundry-bin-latest-${foundry_cache_version}
   - rust/install: {}
-  - run: |
-      if [ ! -d ~/.foundry ]; then
-        curl -L https://foundry.paradigm.xyz | bash
-        echo 'export PATH="$PATH:$HOME/.foundry/bin"' >> ~/.bashrc
-        source ~/.bashrc
-        foundryup
-      fi
-      rm -rf *
-      echo 'export PATH="$PATH:$HOME/.foundry/bin"' >> ~/.bashrc
-      source ~/.bashrc
+  - run: 
+        name: "Install Foundry"
+        working_directory: ~/
+        environment:
+          SHELL: /bin/bash
+        command: |-
+            export PATH="$PATH:$HOME/.foundry/bin"
+            echo 'export PATH=$PATH:$HOME/.foundry/bin' >> $BASH_ENV
+
+            if command -v anvil; then
+              echo "Anvil already installed"
+              anvil --version
+            else
+              curl -L https://foundry.paradigm.xyz | bash
+              foundryup
+            fi
+            rm -rf *
 
   - save_cache:
-      key: foundry-bin-${foundry_locked_commit}-14
+      key: foundry-bin-latest-${foundry_cache_version}
       paths:
         - ~/.foundry/bin
 

diff --git a/.circleci/src/jobs/job-integration-tests.yml b/.circleci/src/jobs/job-integration-tests.yml
@@ -8,21 +8,28 @@ steps:
   # get foundry
   - restore_cache:
       keys:
-        - foundry-bin-${foundry_locked_commit}-14
+        - foundry-bin-latest-${foundry_cache_version}
   - rust/install: {}
-  - run: |
-      if [ ! -d ~/.foundry ]; then
-        curl -L https://foundry.paradigm.xyz | bash
-        echo 'export PATH="$PATH:$HOME/.foundry/bin"' >> ~/.bashrc
-        source ~/.bashrc
-        foundryup
-      fi
-      rm -rf *
-      echo 'export PATH="$PATH:$HOME/.foundry/bin"' >> ~/.bashrc
-      source ~/.bashrc
+  - run: 
+        name: "Install Foundry"
+        working_directory: ~/
+        environment:
+          SHELL: /bin/bash
+        command: |-
+            export PATH="$PATH:$HOME/.foundry/bin"
+            echo 'export PATH=$PATH:$HOME/.foundry/bin' >> $BASH_ENV
+
+            if command -v anvil; then
+              echo "Anvil already installed"
+              anvil --version
+            else
+              curl -L https://foundry.paradigm.xyz | bash
+              foundryup
+            fi
+            rm -rf *
 
   - save_cache:
-      key: foundry-bin-${foundry_locked_commit}-14
+      key: foundry-bin-latest-${foundry_cache_version}
       paths:
         - ~/.foundry/bin
 

diff --git a/.circleci/src/snippets/job-header-machine.yml b/.circleci/src/snippets/job-header-machine.yml
@@ -3,4 +3,4 @@ machine:
   image: ubuntu-2204:2022.04.1
   docker_layer_caching: true
 environment:
-  foundry_locked_commit: "232f66f9"
+  foundry_cache_version: "1"