Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancellation cost calculation for keepers #2348

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Cancellation cost calculation for keepers #2348

wants to merge 8 commits into from

Conversation

0xMithrandir
Copy link
Contributor

No description provided.

@0xMithrandir 0xMithrandir marked this pull request as ready for review December 13, 2024 14:30
dbeal-eth
dbeal-eth approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to note that the setCosts call signature has changed, and this will likely required deployments repo changes on the next release.

@0xMithrandir
Copy link
Contributor Author

might want to note that the setCosts call signature has changed, and this will likely required deployments repo changes on the next release.

@kaleb-keny actually simplified this PR quite a lot, we are now just reusing settlementRewardCost instead of adding cancel gas units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeal-eth dbeal-eth dbeal-eth approved these changes

@kaleb-keny kaleb-keny Awaiting requested review from kaleb-keny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xMithrandir @dbeal-eth