Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: expose isWithinMarketCapacity view function #2345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature: expose isWithinMarketCapacity view function #2345

wants to merge 1 commit into from

Conversation

ProblematicP
Copy link

Want to do something similar to this

synthetix-v3/markets/perps-market/contracts/storage/AsyncOrder.sol

Line 371 in 306c928

GlobalPerpsMarket.load().validateMarketCapacity(lockedCreditDelta);

but making it simpler as view function using this

synthetix-v3/markets/perps-market/contracts/storage/GlobalPerpsMarket.sol

Line 100 in 306c928

function isMarketSolventForCreditDelta(

dbeal-eth
dbeal-eth reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks ok, are you working on getting a test?

@ProblematicP
Copy link
Author

Generally looks ok, are you working on getting a test?

plan to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeal-eth dbeal-eth dbeal-eth left review comments

@noisekit noisekit Awaiting requested review from noisekit

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProblematicP @dbeal-eth