Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Confirm transaction test cases with Cypress #1214

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

matstyler
Copy link
Collaborator

Motivation and context

The goal of this PR is to add test cases for transaction confirmation using Cypress. To do so a new function -getAccountAddress together with some updates for confirmTransaction had to be delivered.

Does it fix any issue?

https://linear.app/synpress/issue/SYN-134/confirm-transaction-with-cypress

Other useful info

N/A

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 8:12am

@matstyler matstyler requested a review from drptbl September 6, 2024 23:39
@matstyler matstyler changed the title feat: confirm transaction test cases with Cypress ✨ feat: confirm transaction test cases with Cypress Sep 8, 2024
@matstyler matstyler changed the title ✨ feat: confirm transaction test cases with Cypress ✨ feat: Confirm transaction test cases with Cypress Sep 9, 2024
@@ -6,7 +6,7 @@ export default defineConfig({
chromeWebSecurity: true,
e2e: {
baseUrl: 'http://localhost:9999',
specPattern: 'test/cypress/**/*.cy.{js,jsx,ts,tsx}',
specPattern: 'test/cypress/**/confirmTransaction.cy.{js,jsx,ts,tsx}',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@matstyler matstyler merged commit 93fdc94 into new-dawn Sep 11, 2024
9 checks passed
@matstyler matstyler deleted the feat/confirm-transaction-with-cypress branch September 11, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants