Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Implemented connectToDapp, addNewAccount in Cypress #1181

Merged
merged 17 commits into from
Jul 25, 2024

Conversation

matstyler
Copy link
Collaborator

@matstyler matstyler commented Jul 17, 2024

Motivation and context

Improved Cypress/Metamask stability. Implemented first Cypress test cases with Metamask - connectToDapp and addNewAccount.

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 10:28am

/**
* The password of the MetaMask wallet.
*/
readonly password: string,

Check warning

Code scanning / CodeQL

Useless assignment to property Warning

This write to property 'password' is useless, since
another property write
always overrides it.
@matstyler matstyler changed the title Feat/metamask api with cypress ✨ feat: connectToDapp api with Cypress Jul 18, 2024
@matstyler matstyler marked this pull request as ready for review July 18, 2024 22:49
@matstyler matstyler changed the title ✨ feat: connectToDapp api with Cypress ✨ feat: function connectToDapp with Cypress Jul 19, 2024
@matstyler matstyler requested a review from drptbl July 19, 2024 22:21
@matstyler matstyler changed the title ✨ feat: function connectToDapp with Cypress ✨ feat: Function connectToDapp with Cypress Jul 20, 2024
@matstyler matstyler changed the title ✨ feat: Function connectToDapp with Cypress ✨ feat: Implemented connectToDapp, addNewAccount and helpers in Cypress Jul 22, 2024
@matstyler matstyler changed the title ✨ feat: Implemented connectToDapp, addNewAccount and helpers in Cypress ✨ feat: Implemented connectToDapp, addNewAccount in Cypress Jul 22, 2024
@drptbl drptbl merged commit c04c809 into new-dawn Jul 25, 2024
9 checks passed
@drptbl drptbl deleted the feat/metamask-api-with-cypress branch July 25, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants