Unskip tests for *MetamaskToAddNetwork and *MetamaskToSwitchNetwork

Synthetixio · Aug 16, 2023 · b5485f3 · b5485f3
1 parent f506616
commit b5485f3
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 6 deletions.
diff --git a/docker-compose.ci.yml b/docker-compose.ci.yml
@@ -113,5 +113,19 @@ services:
     networks:
       - x11
 
+  foundry-metamask-test-dapp:
+    profiles:
+      - foundry
+    container_name: foundry
+    image: synthetixio/foundry:457bb48776c3b14de232d9dda620ba9188dc40ac-base
+    # Port and chain id as required by the MetaMask Test Dapp
+    command: [ 'anvil --no-cors --port 8546 --chain-id 1338' ]
+    environment:
+      - ANVIL_IP_ADDR=0.0.0.0
+    ports:
+      - '8546:8546'
+    networks:
+      - x11
+
 networks:
   x11:
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -84,5 +84,19 @@ services:
     networks:
       - x11
 
+  foundry-metamask-test-dapp:
+    profiles:
+      - foundry
+    container_name: foundry
+    image: synthetixio/foundry:457bb48776c3b14de232d9dda620ba9188dc40ac-base
+    # Port and chain id as required by the MetaMask Test Dapp
+    command: [ 'anvil --no-cors --port 8546 --chain-id 1338' ]
+    environment:
+      - ANVIL_IP_ADDR=0.0.0.0
+    ports:
+      - '8546:8546'
+    networks:
+      - x11
+
 networks:
   x11:
diff --git a/tests/e2e/specs/metamask-spec.js b/tests/e2e/specs/metamask-spec.js
@@ -436,25 +436,24 @@ describe('Metamask', () => {
         expect(approved).to.be.true;
       });
     });
-    // todo: this feature is broken inside test-dapp, needs to be fixed (unable to switch to DAI chain)
-    it.skip(`rejectMetamaskToAddNetwork should reject permission to add network`, () => {
+    it(`rejectMetamaskToAddNetwork should reject permission to add network`, () => {
       cy.get('#addEthereumChain').click();
       cy.rejectMetamaskToAddNetwork().then(rejected => {
         expect(rejected).to.be.true;
       });
     });
-    it.skip(`allowMetamaskToAddNetwork should approve permission to add network`, () => {
+    it(`allowMetamaskToAddNetwork should approve permission to add network`, () => {
       cy.get('#addEthereumChain').click();
-      cy.allowMetamaskToAddNetwork('close').then(approved => {
+      cy.allowMetamaskToAddNetwork().then(approved => {
         expect(approved).to.be.true;
       });
     });
-    it.skip(`rejectMetamaskToSwitchNetwork should reject permission to switch network`, () => {
+    it(`rejectMetamaskToSwitchNetwork should reject permission to switch network`, () => {
       cy.rejectMetamaskToSwitchNetwork().then(rejected => {
         expect(rejected).to.be.true;
       });
     });
-    it.skip(`allowMetamaskToSwitchNetwork should approve permission to switch network`, () => {
+    it(`allowMetamaskToSwitchNetwork should approve permission to switch network`, () => {
       cy.get('#switchEthereumChain').click();
       cy.allowMetamaskToSwitchNetwork().then(approved => {
         expect(approved).to.be.true;