Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude locked collateral from available to withdraw. #121

Merged
merged 12 commits into from
Dec 22, 2024
Merged

Exclude locked collateral from available to withdraw. #121

merged 12 commits into from
Dec 22, 2024

Conversation

peiman3
Copy link
Contributor

@peiman3 peiman3 commented Dec 20, 2024 •
edited
Loading

Screenshot 2024-12-20 at 7 13 06 PM Screenshot 2024-12-20 at 7 15 12 PM

@peiman3 peiman3 added the bug Something isn't working label Dec 20, 2024
@peiman3 peiman3 requested a review from noisekit December 20, 2024 13:00
@peiman3 peiman3 self-assigned this Dec 20, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 11:42am

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.36%. Comparing base (cbdacd8) to head (525eaa2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...y/lib/useAccountCollateral/useAccountCollateral.ts 90.90% 2 Missing ⚠️
liquidity/ui/src/components/Withdraw/Withdraw.tsx 83.33% 2 Missing ⚠️
...idity/ui/src/components/Manage/CollateralStats.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   66.51%   66.36%   -0.15%     
==========================================
  Files         262      263       +1     
  Lines        6418     6449      +31     
  Branches     2083     2087       +4     
==========================================
+ Hits         4269     4280      +11     
- Misses       2149     2169      +20
Files with missing lines Coverage Δ
...idity/components/ClaimModal/ClaimSuccessBanner.tsx 0.00% <ø> (ø)
...idity/ui/src/components/Positions/PositionsRow.tsx 56.25% <100.00%> (-0.28%) ⬇️
...idity/ui/src/components/Manage/CollateralStats.tsx 89.47% <66.66%> (-4.28%) ⬇️
...y/lib/useAccountCollateral/useAccountCollateral.ts 90.90% <90.90%> (ø)
liquidity/ui/src/components/Withdraw/Withdraw.tsx 96.07% <83.33%> (-1.80%) ⬇️

... and 5 files with indirect coverage changes

@noisekit noisekit force-pushed the locked-collateral-amount branch from a416830 to e5c0edb Compare December 22, 2024 06:12
@noisekit noisekit force-pushed the locked-collateral-amount branch from fd31eb8 to 525eaa2 Compare December 22, 2024 11:41
@noisekit noisekit merged commit d3749a0 into master Dec 22, 2024
10 of 11 checks passed
@noisekit noisekit deleted the locked-collateral-amount branch December 22, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisekit noisekit noisekit approved these changes

Assignees

@peiman3 peiman3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peiman3 @noisekit